adapt stdout to upstream changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raduchis
previously approved these changes
Mar 11, 2024
ssd04
previously approved these changes
Mar 11, 2024
process/firehoseDataProcessor.go
Outdated
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("could not write %s prefix , err: %w", endBlockPrefix, err) | ||
| return fmt.Errorf("could not write %s , err: %w", blockPrefix, err) |
There was a problem hiding this comment.
now that we have only one entry line and there is just blockPrefix, i don't think it's useful anymore to have it into the error message
There was a problem hiding this comment.
right, will just propagate the error as it is
ssd04
previously approved these changes
Mar 11, 2024
ssd04
approved these changes
Mar 19, 2024
raduchis
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.